On Wed, Nov 04, 2009 at 09:14:45PM +0900, jassi brar wrote: > One of the purposes of this list was to catch trivial mistakes in the > patches before they are sent upstream for maintainer review. That should help > save maintainers time and keep them 'receptive' to samsung's patches. Speaking as one of these upstreams it's not surprising to see issues in submissions, especially where the drivers are from people who are not regular contributors to the subsystem. Like I say, there are some things where a lot of cleanup is required where not posting does make sense but much of the code that is being posted is of a perfectly reasonable standard. For example, even with posting initially to this list the first response wasn't raising fundamental issues so there should be no reason not to have moved upstream with the second round. Some of the other SoCs have followed an approach similar to this one - it tends to cause bad experiences with code never getting merged and with developers becoming reluctant to work with the general kernel community since they become used to the platform-specific environment which gives limited subsystem-specific feedback. > Second purpose being peer review withing samsung. Sure, and it does make sense to also send the patches to this list when submitting upstream - it's also useful for people outside Samsung to keep up to speed on all the latest kernel support for their boards. I think it's a really good idea to have the list and keep it in the loop like that. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |