On Tue, Nov 03, 2009 at 03:59:46PM +0900, jassi brar wrote:
> On Mon, Nov 2, 2009 at 8:39 PM, Ben Dooks <ben@xxxxxxxxxxxxxxxxx> wrote:
> >> > + if (!base) {
> >> > + struct resource *res = platform_get_resource(pdev,
> >> > + IORESOURCE_MEM,
> >> > + 0);
> > I would like to see platform_devices with their proper resources being
> > mandatory for new drivers. We could do with this lot proplerly following
> > the device driver model.
> sorry, i didn't get it. could u please clarify more?
You should just be unconditionally using the resources obtained with
platform_get_resource() - the only reason the I2S driver permits the
base address to be passed in is to deal with the fact that the old
s3c24xx drivers didn't use the device model.
Since you don't have the core code shared between multiple drivers like
I2S you could just roll this code into the main probe function too.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
