Re: [PATCH 4/4] S3C64XX DSP: Added the CPU driver for PCM controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +	dai->private_data = dsp;
> > +
> > +	if (!base) {
> > +		struct resource *res = platform_get_resource(pdev,
> > +							     IORESOURCE_MEM,
> > +							     0);
> > +		if (!res) {
> > +			dev_err(dev, "Unable to get register resource\n");
> > +			return -ENXIO;
> > +		}
> > +
> > +		if (!request_mem_region(res->start, resource_size(res),
> > +					"s3c64xx-dsp")) {
> > +			dev_err(dev, "Unable to request register region\n");
> > +			return -EBUSY;
> > +		}
> > +
> > +		base = res->start;
> > +	}

I would like to see platform_devices with their proper resources being
mandatory for new drivers. We could do with this lot proplerly following
the device driver model.

> > +/* Module information */
> > +MODULE_AUTHOR("Jaswinder Singh, <jassi.brar@xxxxxxxxxxx>");
> > +MODULE_DESCRIPTION("S3C64XX PCM Controller Driver");

no module license.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC Development]     [Linux Rockchip Development]     [Linux USB Development]     [Video for Linux]     [Linux Audio Users]     [Linux SCSI]     [Yosemite News]

  Powered by Linux