On Mon, Nov 2, 2009 at 8:39 PM, Ben Dooks <ben@xxxxxxxxxxxxxxxxx> wrote:
>
>> > + dai->private_data = dsp;
>> > +
>> > + if (!base) {
>> > + struct resource *res = platform_get_resource(pdev,
>> > + IORESOURCE_MEM,
>> > + 0);
>> > + if (!res) {
>> > + dev_err(dev, "Unable to get register resource\n");
>> > + return -ENXIO;
>> > + }
>> > +
>> > + if (!request_mem_region(res->start, resource_size(res),
>> > + "s3c64xx-dsp")) {
>> > + dev_err(dev, "Unable to request register region\n");
>> > + return -EBUSY;
>> > + }
>> > +
>> > + base = res->start;
>> > + }
>
> I would like to see platform_devices with their proper resources being
> mandatory for new drivers. We could do with this lot proplerly following
> the device driver model.
sorry, i didn't get it. could u please clarify more?
>> > +/* Module information */
>> > +MODULE_AUTHOR("Jaswinder Singh, <jassi.brar@xxxxxxxxxxx>");
>> > +MODULE_DESCRIPTION("S3C64XX PCM Controller Driver");
>
> no module license.
I missed that, will add. thanks.
>
> --
> Ben
>
> Q: What's a light-year?
> A: One-third less calories than a regular year.
>
>
��.n��������+%������w��{.n�����{��Ʀ����)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
