On Mon, Sep 28, 2009 at 8:10 PM, <thomas.ab@xxxxxxxxxxx> wrote: > + clk_set_parent(&clk_mmc0.clk, &clk_dout_mpll); > + clk_set_parent(&clk_mmc1.clk, &clk_dout_mpll); > + clk_set_parent(&clk_mmc2.clk, &clk_dout_mpll); People might object to setting parents here, albeit as defaults. If these settings are not unnecessary, these shud either be done in mach specific code or by a platform func called, with clk and parent as args, from the mach specific code. > for (ptr = 0; ptr < ARRAY_SIZE(init_parents); ptr++) > s3c6400_set_clksrc(init_parents[ptr]); > + > + clk_set_rate(&clk_mmc0.clk, 50*MHZ); > + clk_set_rate(&clk_mmc1.clk, 50*MHZ); > + clk_set_rate(&clk_mmc2.clk, 50*MHZ); same here, i think. Or the rate value passed as plat data from the mach specific code and set as default in mmc-probe. wot say gurus? -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
 |