On Thu, Nov 30, 2023 at 05:22:33PM -0700, Nathan Chancellor wrote: Hi Nathan, > When building with -Wmissing-prototypes without CONFIG_GENERIC_BUG, > there is a warning about a missing prototype for is_valid_bugaddr(): > > arch/s390/kernel/traps.c:46:5: warning: no previous prototype for 'is_valid_bugaddr' [-Wmissing-prototypes] > 46 | int is_valid_bugaddr(unsigned long addr) > | ^~~~~~~~~~~~~~~~ > > The prototype is only declared with CONFIG_GENERIC_BUG, so only define > the function under the same condition to clear up the warning, which > matches other architectures. Thanks for the fix! The patch is fine, although I have not been able to reproduce the warning. How did you trigger it? > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx> > --- > arch/s390/kernel/traps.c | 2 ++ > 1 file changed, 2 insertions(+) ... Thanks!
