On Thu, Nov 30, 2023 at 05:22:32PM -0700, Nathan Chancellor wrote:
> With CONFIG_DASD_PROFILE=n, there is a warning that
> dasd_stats_generic_show() is missing a prototype:
>
> drivers/s390/block/dasd.c:1109:5: warning: no previous prototype for 'dasd_stats_generic_show' [-Wmissing-prototypes]
> 1109 | int dasd_stats_generic_show(struct seq_file *m, void *v)
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> This function has been unused since its introduction in
> commit 4fa52aa7a82f ("[S390] dasd: add enhanced DASD statistics
> interface"), remove it to clear up the warning.
>
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
> Cc: sth@xxxxxxxxxxxxx
> Cc: hoeppner@xxxxxxxxxxxxx
> ---
> drivers/s390/block/dasd.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
> index 833cfab7d877..7327e81352e9 100644
> --- a/drivers/s390/block/dasd.c
> +++ b/drivers/s390/block/dasd.c
> @@ -1106,12 +1106,6 @@ static void dasd_statistics_removeroot(void)
> return;
> }
>
> -int dasd_stats_generic_show(struct seq_file *m, void *v)
> -{
> - seq_puts(m, "Statistics are not activated in this kernel\n");
> - return 0;
> -}
> -
> static void dasd_profile_init(struct dasd_profile *profile,
> struct dentry *base_dentry)
> {
>
Acked-by: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>
