On 2023/12/2 00:32, Alexandra Winter wrote:
On 30.11.23 12:28, Wen Gu wrote:
The fourth edition of SMCv2 adds the SMC version 2.1 feature updates for
SMC-Dv2 with virtual ISM. Virtual ISM are created and supported mainly by
OS or hypervisor software, comparable to IBM ISM which is based on platform
firmware or hardware.
With the introduction of virtual ISM, SMCv2.1 makes some updates:
- Introduce feature bitmask to indicate supplemental features.
- Reserve a range of CHIDs for virtual ISM.
- Support extended GIDs (128 bits) in CLC handshake.
So this patch set aims to implement these updates in Linux kernel. And it
acts as the first part of SMC-D virtual ISM extension & loopback-ism [1].
[1] https://lore.kernel.org/netdev/1695568613-125057-1-git-send-email-guwen@xxxxxxxxxxxxxxxxx/
v3->v2:
- Rename smc_clc_fill_fce as smc_clc_fill_fce_v2x;
- Remove ISM_IDENT_MASK from drivers/s390/net/ism.h;
- Add explicitly assigning 'false' to ism_v2_capable in ism_dev_init();
- Remove smc_ism_set_v2_capable() helper for now, and introduce it in
later loopback-ism implementation;
v2->v1:
- Fix sparse complaint;
- Rebase to the latest net-next;
Wen Gu (7):
net/smc: Rename some variable 'fce' to 'fce_v2x' for clarity
net/smc: support SMCv2.x supplemental features negotiation
net/smc: introduce virtual ISM device support feature
net/smc: define a reserved CHID range for virtual ISM devices
net/smc: compatible with 128-bits extend GID of virtual ISM device
net/smc: disable SEID on non-s390 archs where virtual ISM may be used
net/smc: manage system EID in SMC stack instead of ISM driver
Wen Gu,
as you can see in [1] your patches 5/7 and 1/7 still have formatting issues.
In this case they need to pass
scripts/checkpatch.pl --strict --max-line-length=80
(see linux/Documentation/process/coding-style.rst)
[1] https://patchwork.kernel.org/project/netdevbpf/list/?series=&submitter=&state=&q=net%2Fsmc&archive=&delegate=
Thanks. They will be fixed and I will check the patches with tests provided by
https://github.com/kuba-moo/nipa/tree/master/tests/patch
