On Thu, 18 May 2017, Christoph Hellwig wrote:
> On Thu, May 18, 2017 at 10:24:48AM +0200, Christoph Hellwig wrote:
> > > b) give the union a name (breaks any reference to timer_list->func in C code):
> > >
> > > + union {
> > > + void (*func)(struct timer_list *timer);
> > > + void (*function)(unsigned long);
> > > + } u;
> >
> > I'll look into that, as it seems a lot safer, and places outside
> > the timer code shouldn't really touch it (although I bet they do,
> > so more fixes for this series..)
>
> Meh. All the old init_timer users set function directly, so
> I guess we need to use the other approach.
There is another possibility. Create a coccinelle script which wraps all
timer.function = f;
timer->function = f;
assignements into a helper timer_set_function(timer, func) and ask Linus to
run it right before the next -rc. That handles everything in tree and the
few new instances in next can be addressed with patches sent to the
maintainers.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
