On Sun, 21 May 2017, Thomas Gleixner wrote:
> On Tue, 16 May 2017, Arnd Bergmann wrote:
> > On Tue, May 16, 2017 at 5:51 PM, Christoph Hellwig <hch@xxxxxx> wrote:
> > > Yes, that sounds useful to me as well. As you said it's an independent
> > > but somewhat related change. I can add it to my series, but I'll
> > > need a suggestions for a good and short name. That already was the
> > > hardest part for the setup side :)
> >
> > If we keep the unusual *_timer() naming (rather than timer_*() as hrtimer
> > has), we could use one of
> >
> > a) start_timer(struct timer_list *timer, unsigned long ms);
> > b) restart_timer(struct timer_list *timer, unsigned long ms);
> > c) mod_timer_ms(struct timer_list *timer, unsigned long ms);
> > mod_timer_sec(struct timer_list *timer, unsigned long sec);
>
> Please make new functions prefixed with timer_ and get rid of that old
> interface completely. It's horrible.
>
> timer_init()
> timer_start(timer, ms, abs)
I'm not even sure, whether we need absolute timer wheel timers at
all, because most use cases are relative to now.
But it's easy enough to provide them. All we need for that is something
like
unsigned long time_msec;
which gets incremented every tick by the appropriate amount of
milliseconds.
Having that would also allow to replace all the
end = jiffies + msec_to_jiffies(xxx);
while (time_before(jiffies, end))
....
constructs with a milliseconds based machinery. So we can remove all
*_to_jiffies() interfaces over time.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
