Re: [PATCH 1/1] dasd: do not force use of deadline IO scheduler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Considering the call trace you sent:
> > 
> > > -	elevator_exit(block->request_queue->elevator);
> > > -	rc = elevator_init(block->request_queue, "deadline");
> > 
> > block->request_queue->elevator = NULL is missing here.
> > 
> > > -	if (rc) {
> > > -		blk_cleanup_queue(block->request_queue);
> > > -		return rc;
> > > -	}
> > 
> > Fallback to noop and printing a warning wouldn't be bad.
> 
> Is noop better than the default (e.g., CFQ)?
> 
> I was thinking that if the deadline init fails, we put back the old elevator
> - whatever it may be.
> 
> > In addition something like depends on IOSCHED_DEADLINE should be added to
> > the Kconfig file.
> 
> Alright, so...
> 
> 1) Kconfig change, ->elevator = NULL

That should be the way to go, since we want the deadline scheduler.
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux