On Mon, Mar 03, 2008 at 03:21:04PM -0500, Josef 'Jeff' Sipek wrote:
> Signed-off-by: Josef 'Jeff' Sipek <jeffpc@xxxxxxxxxxxxxx>
> ---
> drivers/s390/block/dasd.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
> index ccf46c9..4d4f6ff 100644
> --- a/drivers/s390/block/dasd.c
> +++ b/drivers/s390/block/dasd.c
> @@ -1946,21 +1946,12 @@ static void do_dasd_request(struct request_queue *queue)
> */
> static int dasd_alloc_queue(struct dasd_block *block)
> {
> - int rc;
> -
> block->request_queue = blk_init_queue(do_dasd_request,
> &block->request_queue_lock);
> if (block->request_queue == NULL)
> return -ENOMEM;
>
> block->request_queue->queuedata = block;
> -
Considering the call trace you sent:
> - elevator_exit(block->request_queue->elevator);
> - rc = elevator_init(block->request_queue, "deadline");
block->request_queue->elevator = NULL is missing here.
> - if (rc) {
> - blk_cleanup_queue(block->request_queue);
> - return rc;
> - }
Fallback to noop and printing a warning wouldn't be bad.
In addition something like depends on IOSCHED_DEADLINE should be added to
the Kconfig file.
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
