On Tue, Mar 04, 2008 at 11:31:45AM +0100, Heiko Carstens wrote:
> On Mon, Mar 03, 2008 at 03:21:04PM -0500, Josef 'Jeff' Sipek wrote:
...
> Considering the call trace you sent:
>
> > - elevator_exit(block->request_queue->elevator);
> > - rc = elevator_init(block->request_queue, "deadline");
>
> block->request_queue->elevator = NULL is missing here.
>
> > - if (rc) {
> > - blk_cleanup_queue(block->request_queue);
> > - return rc;
> > - }
>
> Fallback to noop and printing a warning wouldn't be bad.
Is noop better than the default (e.g., CFQ)?
I was thinking that if the deadline init fails, we put back the old elevator
- whatever it may be.
> In addition something like depends on IOSCHED_DEADLINE should be added to
> the Kconfig file.
Alright, so...
1) Kconfig change, ->elevator = NULL
or
2) if deadline load fails, go back to whatever was there (and issue a
warning?)
Josef 'Jeff' Sipek.
--
Keyboard not found!
Press F1 to enter Setup
--
To unsubscribe from this list: send the line "unsubscribe linux-s390" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
