Re: [PATCH] rtc: add support for NXP PCF85363 real-time clock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Eric,

On Mon, Oct 9, 2017 at 4:41 PM, Eric Nelson <eric@xxxxxxxxxx> wrote:

> +config RTC_DRV_PCF85363
> +       tristate "NXP PCF85363"
> +       depends on I2C

It seems you missed a dependency on REGMAP_I2C.

> +static const struct i2c_device_id pcf85363_id[] = {
> +       { "pcf85363", 0 },
> +       { }
> +};
> +MODULE_DEVICE_TABLE(i2c, pcf85363_id);

Even though the driver can probe via the i2c device id, it is
recommended to explicitly pass the compatible string:

static const struct of_device_id pcf85363_dt_match[] = {
{ .compatible = "nxp,pcf85363" },
{ },

See this previous discussion:
https://www.spinics.net/lists/devicetree/msg195176.html



[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux