Hi Fabio,
On 10/10/2017 06:31 AM, Fabio Estevam wrote:
Hi Eric,
On Mon, Oct 9, 2017 at 4:41 PM, Eric Nelson <eric@xxxxxxxxxx> wrote:
+config RTC_DRV_PCF85363
+ tristate "NXP PCF85363"
+ depends on I2C
It seems you missed a dependency on REGMAP_I2C.
Nice catch. Thanks.
+static const struct i2c_device_id pcf85363_id[] = {
+ { "pcf85363", 0 },
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, pcf85363_id);
Even though the driver can probe via the i2c device id, it is
recommended to explicitly pass the compatible string:
static const struct of_device_id pcf85363_dt_match[] = {
{ .compatible = "nxp,pcf85363" },
{ },
See this previous discussion:
https://www.spinics.net/lists/devicetree/msg195176.html
Thanks for that, too.
I'll fix this up in V2.
