Re: [rteval PATCH] rteval: stressng.py: Fix argument passing to Popen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 30 Jul 2021 13:35:08 +0900 (JST), Atsushi Nemoto <atsushi.nemoto@xxxxxxxxxx> wrote:
>> If you want for example to run the stress-ng memcpy test with an argument 
>> of N=8 for 8 workers with a timeout of ten seconds you do this
>> 
>> rteval -d1m --loads-cpulist='0-4' --stressng-option=memcpy 
>> --stressng-arg=8 --stressng-timeout=10
>> 
>> which will result in rteval running the following command
>> stress-ng --memcpy 8 --timeout 10 --taskset 0,1,2,3,4
> 
> In this case, the self.args will be:
> 
> 	["stress-ng", "--memcpy", "8", "--timeout 10", "--taskset 0,1,2,3,4"]
> 
> and will cause "stress-ng: unrecognized option '--timeout 10'" error.
> 
> If "shell=True" is not acceptable, how about this?
> 
>     self.process = subprocess.Popen(" ".join(self.args).split(),

Instead of this, spliting "--timeout 10" to ["--timeout", "10"] would
be better?

I will post another patch.

---
Atsushi Nemoto



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux