Re: [rteval PATCH] rteval: stressng.py: Fix argument passing to Popen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 Jul 2021 17:38:05 -0400 (EDT), John Kacur <jkacur@xxxxxxxxxx> wrote:
>> -            self.process = subprocess.Popen(self.args,
>> +            self.process = subprocess.Popen(" ".join(self.args), shell=True,
>>                                              stdout=self.__out,
>>                                              stderr=self.__err,
>>                                              stdin=self.__in)
>> -- 
>> 2.11.0
>> 
> 
> I don't see the need to do this here and in fact there are some security 
> implications to using shell=True. Is there a reason you want to do this?

I want to pass multiple options using --stressng-arg.

And also, there are elements with spaces in self.args already:
"--timeout %s" and "--taskset %s".

---
Atsushi Nemoto



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux