Re: [rteval PATCH] rteval: stressng.py: Fix argument passing to Popen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, 29 Jul 2021, Atsushi Nemoto wrote:

> On Wed, 28 Jul 2021 17:38:05 -0400 (EDT), John Kacur <jkacur@xxxxxxxxxx> wrote:
> >> -            self.process = subprocess.Popen(self.args,
> >> +            self.process = subprocess.Popen(" ".join(self.args), shell=True,
> >>                                              stdout=self.__out,
> >>                                              stderr=self.__err,
> >>                                              stdin=self.__in)
> >> -- 
> >> 2.11.0
> >> 
> > 
> > I don't see the need to do this here and in fact there are some security 
> > implications to using shell=True. Is there a reason you want to do this?
> 
> I want to pass multiple options using --stressng-arg.
> 
> And also, there are elements with spaces in self.args already:
> "--timeout %s" and "--taskset %s".
> 
> ---
> Atsushi Nemoto
> 

Running stress-ng as a load in rteval is fairly new and purposely 
contrained so far. So, you can't run multiple tests right now.
However most of what you want to do is already possible.

stress-ng is like any other load so you can specify the taskset like this
--loads-cpulist='0-4'

If you want for example to run the stress-ng memcpy test with an argument 
of N=8 for 8 workers with a timeout of ten seconds you do this

rteval -d1m --loads-cpulist='0-4' --stressng-option=memcpy 
--stressng-arg=8 --stressng-timeout=10

which will result in rteval running the following command
stress-ng --memcpy 8 --timeout 10 --taskset 0,1,2,3,4

John




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux