Hi David, Am Samstag, 6. Oktober 2018, 14:54:37 CEST schrieb David Summers: > Hi Heiko, > > Re: > http://lists.infradead.org/pipermail/linux-rockchip/2018-September/021762.html > > We've just had another use on Arm Arch interested in installing on a > Tinker Board. So this gives the chance to test the wi-fi patch on a > Tinker Board as well as Tinker Board S; so give better of where to apply > the patch. > > So half thinking of having another go at the wi-fi patch. > > But should first check, what problems did you see with the patch? Let me > know and I'll see if I can incorporate in patch update. As much as > anything, I want to minimize the number of tb{s}.dtb that I send out to > arch arm users, as testing before submission. E.g. the users have > limited tolerance, may be able to try a few device trees with them - but > if it takes too many iterations, they will just switch to linarno kernel ... I did seem to have procrastinated a bit with my reply there, sorry about that. I've replied to the original patch now. Heiko > > Ta, > > David. > > On 23/09/2018 12:38, Heiko Stuebner wrote: > > Hi David, > > > > I've adpated your patches 1+2 like so and would like to add them this way > > later on. Biggest change is of course making patch 1 solely about moving > > the shared parts to the dtsi and adding the tinker-s.dts including the > > emmc in the second patch. > > > > Apart from that you can also see some previously missing style-related > > fixes. For example patch subject lines are somewhat specific, to allow > > people browsing the git history to realize the core patch contents just > > from the "headline" and also use the "correct" prefixes which vary > > depending on the subsystem your changing. > > > > For future patches you can just do a "git log --oneline arch/arm/boot/dts" > > (change directory depending on location of the change of course), to > > see that arm32 dts use "ARM: dts: $soc-vendor: foo". > > > > > > Also providing a commit message describing the individual change > > in a bit more detail is important. > > > > The wifi patch is a different issue, so I'll reply there. > > > > > > Heiko > > > > David Summers (2): > > ARM: dts: rockchip: move shared tinker-board nodes to a common dtsi > > ARM: dts: rockchip: add rk3288-based Tinker board S > > > > .../devicetree/bindings/arm/rockchip.txt | 4 + > > arch/arm/boot/dts/Makefile | 1 + > > arch/arm/boot/dts/rk3288-tinker-s.dts | 26 + > > arch/arm/boot/dts/rk3288-tinker.dts | 498 +---------------- > > arch/arm/boot/dts/rk3288-tinker.dtsi | 504 ++++++++++++++++++ > > 5 files changed, 537 insertions(+), 496 deletions(-) > > create mode 100644 arch/arm/boot/dts/rk3288-tinker-s.dts > > create mode 100644 arch/arm/boot/dts/rk3288-tinker.dtsi > > > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/linux-rockchip
