Hi, On Mon, Oct 20, 2014 at 4:27 PM, Doug Anderson <dianders at chromium.org> wrote: > @@ -959,9 +968,10 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin, > return rc; > break; > case PIN_CONFIG_OUTPUT: > - rc = rockchip_gpio_direction_output(&bank->gpio_chip, > - pin - bank->pin_base, > - arg); > + rockchip_gpio_set(&bank->gpio_chip, > + pin - bank->pin_base, arg); > + rc = _rockchip_pmx_gpio_set_direction(&bank->gpio_chip, > + pin - bank->pin_base, false); I think something here is not quite right. I did more testing today and noticed that I'm getting failures in some cases. I think I've got the offset wrong, but I'm digging. Please hold off review of this patch till the next version.
