On Fri, Feb 14, 2025 at 09:04:34AM +0100, Geert Uytterhoeven wrote: ... > > > > +static inline u8 i2c_10bit_addr_from_msg(const struct i2c_msg *msg) > > > > > > Having never used 10-bit addressing myself, or even looked into it, > > > it took me a while to understand what this helper really does... > > > So this returns the high byte of the artificial 16-bit address that > > > must be used to address a target that uses 10-bit addressing? > > > Hence I think this should be renamed, to better match its purpose. > > > > It's coherent with i2c_8bit_addr_from_msg(), right? > > Is it? Unlike i2c_8bit_addr_from_msg(), it does not return the full > address, Yeah, hi/lo together will be coherent, hence I sent a v2 with Geert's suggestion being incorporated. -- With Best Regards, Andy Shevchenko
