Hi Andy, On Wed, Feb 12, 2025 at 06:32:26PM +0200, Andy Shevchenko wrote: > There are already a lot of drivers that have been using > i2c_8bit_addr_from_msg() for 7-bit addresses, now it's time > to have the similar for 10-bit addresses. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> ... > +static inline u8 i2c_10bit_addr_from_msg(const struct i2c_msg *msg) > +{ > + /* > + * 10-bit address > + * addr_1: 5'b11110 | addr[9:8] | (R/nW) > + * addr_2: addr[7:0] > + */ > + return 0xf0 | ((msg->addr & GENMASK(9, 8)) >> 7) | (msg->flags & I2C_M_RD); > +} > + I personally like this patch and it was an item of my todo list. I'm OK with having it merged. Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> Andi