Hi Andy, On Fri, Aug 23, 2024 at 5:22 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote: > On Thu, Aug 22, 2024 at 02:14:38PM +0800, Shen Lichuan wrote: > > Let the kememdup_array() take care about > > multiplication and possible overflows. > > > + cfgs = kmemdup_array(configs, num_configs, > > + sizeof(*cfgs), GFP_KERNEL); > > Geert, don't you want to fix the indentation issues? > Perhaps even combining these to a single line? I have already done so while applying ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds