On Fri, Aug 23, 2024 at 11:51:13AM +0800, Rong Qianfeng wrote: > The devm_clk_get_enabled() helpers: > - call devm_clk_get() > - call clk_prepare_enable() and register what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids the calls to clk_disable_unprepare(). ... > ret = platform_get_irq(pdev, 0); > if (ret < 0) > - goto err_clk; > + return ret; > priv->irq = ret; (1) > ret = devm_request_irq(&pdev->dev, priv->irq, em_i2c_irq_handler, 0, > "em_i2c", priv); > if (ret) > - goto err_clk; > + return ret; > > ret = i2c_add_adapter(&priv->adap); > While at it, you may move this blank line to (1) above. > if (ret) > - goto err_clk; > + return ret; -- With Best Regards, Andy Shevchenko
