On Thu, Aug 22, 2024 at 02:14:38PM +0800, Shen Lichuan wrote: > Let the kememdup_array() take care about > multiplication and possible overflows. > + cfgs = kmemdup_array(configs, num_configs, > + sizeof(*cfgs), GFP_KERNEL); Geert, don't you want to fix the indentation issues? Perhaps even combining these to a single line? ... > + cfgs = kmemdup_array(configs, num_configs, > + sizeof(*cfgs), GFP_KERNEL); > if (!cfgs) > return -ENOMEM; Ditto. ... > + cfgs = kmemdup_array(configs, num_configs, > + sizeof(*cfgs), GFP_KERNEL); Ditto. -- With Best Regards, Andy Shevchenko
