On Wed, 24 Apr 2024 at 16:34, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Ulf, > > On Mon, Apr 22, 2024 at 12:54 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote: > > From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > > > > Series adds support for power domains on rzg2l driver. > > > > RZ/G2L kind of devices support a functionality called MSTOP (module > > stop/standby). According to hardware manual the module could be switch > > to standby after its clocks are disabled. The reverse order of operation > > should be done when enabling a module (get the module out of standby, > > enable its clocks etc). > > > > In [1] the MSTOP settings were implemented by adding code in driver > > to attach the MSTOP state to the IP clocks. But it has been proposed > > to implement it as power domain. The result is this series. > > > > The DT bindings were updated with power domain IDs (plain integers > > that matches the DT with driver data structures). The current DT > > bindings were updated with module IDs for the modules listed in tables > > with name "Registers for Module Standby Mode" (see HW manual) exception > > being RZ/G3S where, due to the power down functionality, the DDR, > > TZCDDR, OTFDE_DDR were also added. > > > > Domain IDs were added to all SoC specific bindings. > > > > Thank you, > > Claudiu Beznea > > > > Changes in v4: > > - dropped the pwrdn functionality until it is better understanded > > - dropped patch "clk: renesas: rzg2l-cpg: Add suspend/resume > > support for power domains" from v3; this will be replaced > > by propertly calling device_set_wakup_path() in serial console > > driver > > - instantiated the watchdog domain in r8a08g045 clock driver; this > > allow applying r9a08g045 clock patch w/o affecting watchdog and later, > > after all good with watchdog patches series at [2], only patch > > "arm64: dts: renesas: r9a08g045: Update #power-domain-cells = <1>" > > will need to be applied > > Are you happy with this series? I would like to queue patches 1-7 in > renesas-clk for v6.10 (i.e. this week). Yes, the series looks good to me! For the series, feel free to add: Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Kind regards Uffe
