Hi Krzysztof, Thank you for the review. On Wed, Apr 24, 2024 at 6:42 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 23/04/2024 20:24, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Group single const value items into an enum list. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > v1->v2 > > - Updated commit message > > - Grouped single const value items into an enum list. > > --- > > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++----------- > > 1 file changed, 7 insertions(+), 11 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > index 29f2400247eb..2bf90095742b 100644 > > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > @@ -13,15 +13,13 @@ properties: > > compatible: > > oneOf: > > - items: > > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6 > > - - items: > > - - const: renesas,sdhi-r7s72100 # RZ/A1H > > - - items: > > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5 > > - - items: > > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6 > > - - items: > > - - const: renesas,sdhi-r8a7740 # R-Mobile A1 > > + - enum: > > You wanted to drop the items, but I still see it here. > Ah, I missed that. > > + - renesas,sdhi-sh73a0 # R-Mobile APE6 > > + - renesas,sdhi-r7s72100 # RZ/A1H > > + - renesas,sdhi-r7s9210 # SH-Mobile AG5 > > + - renesas,sdhi-r8a73a4 # R-Mobile APE6 > > + - renesas,sdhi-r8a7740 # R-Mobile A1 > > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C > > Keep list alphabetically ordered. > This list is sorted based on SoC, I will sort it alphabetically. Geert is that OK with you? Cheers, Prabhakar
