RE: [PATCH v3 5/7] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Monday, March 18, 2024 9:25 AM
> Subject: Re: [PATCH v3 5/7] usb: renesas_usbhs: Update usbhs pipe configuration for RZ/G2L family
> 
> Hi Biju,
> 
> On Fri, Mar 15, 2024 at 7:39 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > The RZ/G2L family SoCs has 10 PIPE buffers compared to 16 pipe buffers
> > on RZ/A2M. Update the pipe configuration for RZ/G2L family SoCs and
> > use family SoC specific compatible to handle this difference.
> >
> > Added SoC specific compatible to OF table to avoid ABI breakage with
> > old DTB. To optimize memory usage the SoC specific compatible will be
> > removed later.
> >
> > The pipe configuration of RZ/G2L is same as the default one, so reuse
> > the common table by renaming
> > usbhs_default_pipe[]->usbhs_rcar_default_pipe[]
> > and changing static qualifier to global to fill the pipe configuration
> > data.
> >
> > Signed-off-by: Huy Nguyen <huy.nguyen.wh@xxxxxxxxxxx>
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v2->v3:
> >  * Updated commit description
> >  * Dropped usbhsc_rzg2l_pipe[] and reusing the default_pipe[].
> 
> Thanks for the update!
> 
> > --- a/drivers/usb/renesas_usbhs/common.c
> > +++ b/drivers/usb/renesas_usbhs/common.c
> > @@ -363,8 +363,8 @@ static void usbhsc_clk_disable_unprepare(struct usbhs_priv *priv)
> >   *             platform default param
> >   */
> >
> > -/* commonly used on old SH-Mobile SoCs */ -static struct
> > renesas_usbhs_driver_pipe_config usbhsc_default_pipe[] = {
> > +/* commonly used on old SH-Mobile and RZ/G2L family SoCs */ struct
> > +renesas_usbhs_driver_pipe_config usbhsc_rcar_default_pipe[] = {
> 
> So why rename this to have "rcar" in the name?

Oops, it is not used by R-Car, but used by old SH SoCs and RZ/G2L
As this structure becomes global now, Will use usbhsc_rzg2l_default_pipe[] instead??

Or

Will make this as static like current driver and drop filling pipe configs in info and
use .has_new_pipe_configs to zero for devices using usbhsc_default_pipe[]??

Cheers,
Biju




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux