RE: [PATCH v3 4/7] usb: renesas_usbhs: Drop has_new_pipe_configs from struct renesas_usbhs_driver_param

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Monday, March 18, 2024 9:22 AM
> Subject: Re: [PATCH v3 4/7] usb: renesas_usbhs: Drop has_new_pipe_configs from struct
> renesas_usbhs_driver_param
> 
> Hi Biju,
> 
> On Fri, Mar 15, 2024 at 7:39 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Drop has_new_pipe_configs variable from struct
> > renesas_usbhs_driver_param and use info for getting device pipe
> > configuration data by renaming usbhs_new_pipe[]->usbhs_rcar_pipe[] and
> > changing the static qualifier to global so that struct
> > renesas_usbhs_platform_info can be filled by respective devices.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v3:
> >  * New patch
> 
> Thanks for your patch
> 
> >  drivers/usb/renesas_usbhs/common.c | 9 ++++-----
> > drivers/usb/renesas_usbhs/common.h | 2 ++
> > drivers/usb/renesas_usbhs/rcar2.c  | 3 ++-
> > drivers/usb/renesas_usbhs/rcar3.c  | 6 ++++--
> >  drivers/usb/renesas_usbhs/rza.c    | 3 ++-
> >  drivers/usb/renesas_usbhs/rza2.c   | 3 ++-
> >  include/linux/usb/renesas_usbhs.h  | 1 -
> >  7 files changed, 16 insertions(+), 11 deletions(-)
> 
> Do you need this patch, now RZ/V2H can just set .has_new_pipe_configs to zero?

RZ/V2H has similar configs with RZ/G2L and Old SH SoC's.

So, you mean just set . has_new_pipe_configs to zero
for devices using usbhsc_default_pipe[]??

Cheers,
Biju




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux