Hi, > From: Serge Semin, Sent: Thursday, December 21, 2023 12:21 AM > > Hi Krzysztof, Lorenzo, Bjorn, Mani > > On Wed, Dec 20, 2023 at 02:38:23PM +0900, Yoshihiro Shimoda wrote: > > This patch series tidies the code of PCIe dwc controllers and some > > controllers up. > > > > Changes from v3: > > https://lore.kernel.org/linux-pci/20231215022955.3574063-1-yoshihiro.shimoda.uh@xxxxxxxxxxx/ > > - Based on the latest pci.git / next branch. So, I modified the patch 1/6 > > for pci-layerscape.c. > > - Add Reviewed-by tag in the patch 4/6. > > - Fix locations of read/write accessors by grouped for readability in > > the patch 4/6. > > The series has got all the Mani's acks. The last nitpick was fixed in > v4. No more comments at least from my side. What about merging it in > (before merge window v6.8 is opened)? Serge, thank you for your comment. Hi Krzysztof, Lorenzo, Bjorn, Mani, Would you apply this patch series into pci.git / next branch? I confirmed that the patch series could be applied on the latest pci.git / next branch by using the following git-pw command: $ git-pw --server https://patchwork.kernel.org/api/1.1 --project linux-pci series apply 811670 Best regards, Yoshihiro Shimoda > -Serge(y) > > > > > Changes from v2: > > <snip URL> > > - Based on the latest pci.git / next branch. > > - Add Suggestion-by and Reviewed-by tags. > > - Move read/write accessors to the header file in the patch 4/6. > > - Revise the commit description in the patch 5/6. > > > > Changes from v1: > > <snip URL> > > - Based on the latest pci.git / next branch. > > - Add a new patch to drop host prefix of members from dw_pcie_host_ops > > in the patch 1/6. > > - Add Reviewed-by tag in the patch 3/6. > > - Drop unneeded local variable in the patch 4/6. > > - Add new patches to resolve issues of clang warnings in the patch [56]/6. > > > > Justin Stitt (1): > > PCI: iproc: fix -Wvoid-pointer-to-enum-cast warning > > > > Yoshihiro Shimoda (5): > > PCI: dwc: Drop host prefix from struct dw_pcie_host_ops > > PCI: dwc: Rename to .init in struct dw_pcie_ep_ops > > PCI: dwc: Rename to .get_dbi_offset in struct dw_pcie_ep_ops > > PCI: dwc: Add dw_pcie_ep_{read,write}_dbi[2] helpers > > PCI: rcar-gen4: fix -Wvoid-pointer-to-enum-cast warning > > > > drivers/pci/controller/dwc/pci-dra7xx.c | 4 +- > > drivers/pci/controller/dwc/pci-exynos.c | 2 +- > > drivers/pci/controller/dwc/pci-imx6.c | 6 +- > > drivers/pci/controller/dwc/pci-keystone.c | 8 +- > > .../pci/controller/dwc/pci-layerscape-ep.c | 7 +- > > drivers/pci/controller/dwc/pci-layerscape.c | 6 +- > > drivers/pci/controller/dwc/pci-meson.c | 2 +- > > drivers/pci/controller/dwc/pcie-al.c | 2 +- > > drivers/pci/controller/dwc/pcie-armada8k.c | 2 +- > > drivers/pci/controller/dwc/pcie-artpec6.c | 4 +- > > drivers/pci/controller/dwc/pcie-bt1.c | 4 +- > > .../pci/controller/dwc/pcie-designware-ep.c | 188 ++++++------------ > > .../pci/controller/dwc/pcie-designware-host.c | 30 +-- > > .../pci/controller/dwc/pcie-designware-plat.c | 2 +- > > drivers/pci/controller/dwc/pcie-designware.h | 105 +++++++++- > > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 +- > > drivers/pci/controller/dwc/pcie-fu740.c | 2 +- > > drivers/pci/controller/dwc/pcie-histb.c | 2 +- > > drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +- > > drivers/pci/controller/dwc/pcie-keembay.c | 2 +- > > drivers/pci/controller/dwc/pcie-kirin.c | 2 +- > > drivers/pci/controller/dwc/pcie-qcom-ep.c | 2 +- > > drivers/pci/controller/dwc/pcie-qcom.c | 6 +- > > drivers/pci/controller/dwc/pcie-rcar-gen4.c | 12 +- > > drivers/pci/controller/dwc/pcie-spear13xx.c | 2 +- > > drivers/pci/controller/dwc/pcie-tegra194.c | 2 +- > > drivers/pci/controller/dwc/pcie-uniphier-ep.c | 2 +- > > drivers/pci/controller/dwc/pcie-uniphier.c | 2 +- > > drivers/pci/controller/dwc/pcie-visconti.c | 2 +- > > drivers/pci/controller/pcie-iproc-platform.c | 2 +- > > 30 files changed, 222 insertions(+), 194 deletions(-) > > > > -- > > 2.25.1 > > > >