Hi Andy Shevchenko, > Subject: Re: [PATCH] mfd: max77541: Simplify probe() > > On Sat, Aug 26, 2023 at 10:10:20AM +0100, Biju Das wrote: > > Simplify probe() by replacing device_get_match_data() and ID lookup > > for retrieving match data by i2c_get_match_data(). > > > > While at it, drop leading commas from OF table. > > ... > > > - return -EINVAL; > > + return -ENODEV; > > Why? If I remember correctly, previously you mentioned to return -ENODEV for non-match. I will return -EINVAL. Cheers, Biju
