On Mon, Aug 28, 2023 at 11:36:54AM +0000, Biju Das wrote: > > On Sat, Aug 26, 2023 at 10:10:20AM +0100, Biju Das wrote: ... > > > - return -EINVAL; > > > + return -ENODEV; > > > > Why? > > If I remember correctly, previously you mentioned to return -ENODEV > for non-match. I will return -EINVAL. Maybe I was unclear, I meant to return -ENODEV, if this is a _new_ code. For the existing one, please preserve the error code. -- With Best Regards, Andy Shevchenko