Hi Andy Shevchenko, > Subject: Re: [PATCH] mfd: max8997: Simplify probe() and drop > max8997_i2c_get_driver_data() > > On Sat, Aug 26, 2023 at 10:49:05AM +0100, Biju Das wrote: > > Simplify probe() by using i2c_get_match_data() instead of > > max8997_i2c_get_driver_data() for retrieving match data from OF/ID > > tables. > > ... > > > - max8997->type = max8997_i2c_get_driver_data(i2c, id); > > + max8997->type = (unsigned long)i2c_get_match_data(i2c); > > You need to be consistent inside your patches with the casting... OK, will use uintptr_t for enum casting. Cheers, Biju