Hi Kieran, On Wed, Jul 26, 2023 at 5:45 PM Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote: > Quoting Geert Uytterhoeven (2023-07-26 15:45:57) > > Describe the two General Purpose LEDs LED7 and LED8 on the Spider CPU > > board, so they can be used as indicator LEDs. > > > > Note that General Purpose LEDs LED9 to LED11 are not added, as they are > > connected to GPIO block 4, which can only be accessed from the Control > > Domain. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > I do not have physical access to a Spider development board. > > Thanks for testing! > > In collaboration with Geert, > > Tested-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > > --- > > .../boot/dts/renesas/r8a779f0-spider-cpu.dtsi | 20 +++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > > index dd8e0e1595260b3d..76a94812875ef261 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi > > @@ -6,6 +6,8 @@ > > */ > > > > #include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/leds/common.h> > > + > > #include "r8a779f0.dtsi" > > > > / { > > @@ -22,6 +24,24 @@ chosen { > > stdout-path = "serial0:1843200n8"; > > }; > > > > + leds { > > + compatible = "gpio-leds"; > > + > > + led-7 { > > I presume there is a reason to start the sequence at 7? > But that's fine with me anyway... They're called LED7 and LED8 in the schematics... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds