Re: [PATCH/RFT] arm64: dts: renesas: spider-cpu: Add GP LEDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Geert Uytterhoeven (2023-07-26 15:45:57)
> Describe the two General Purpose LEDs LED7 and LED8 on the Spider CPU
> board, so they can be used as indicator LEDs.
> 
> Note that General Purpose LEDs LED9 to LED11 are not added, as they are
> connected to GPIO block 4, which can only be accessed from the Control
> Domain.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> I do not have physical access to a Spider development board.
> Thanks for testing!

In collaboration with Geert,

Tested-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>

> ---
>  .../boot/dts/renesas/r8a779f0-spider-cpu.dtsi | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi
> index dd8e0e1595260b3d..76a94812875ef261 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi
> @@ -6,6 +6,8 @@
>   */
>  
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> +
>  #include "r8a779f0.dtsi"
>  
>  / {
> @@ -22,6 +24,24 @@ chosen {
>                 stdout-path = "serial0:1843200n8";
>         };
>  
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               led-7 {

I presume there is a reason to start the sequence at 7?
But that's fine with me anyway...

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>

> +                       gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>;
> +                       color = <LED_COLOR_ID_GREEN>;
> +                       function = LED_FUNCTION_INDICATOR;
> +                       function-enumerator = <7>;
> +               };
> +
> +               led-8 {
> +                       gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> +                       color = <LED_COLOR_ID_GREEN>;
> +                       function = LED_FUNCTION_INDICATOR;
> +                       function-enumerator = <8>;
> +               };
> +       };
> +
>         memory@48000000 {
>                 device_type = "memory";
>                 /* first 128MB is reserved for secure area. */
> -- 
> 2.34.1
>




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux