Hi Pavel, Thanks for the feedback. > -----Original Message----- > From: Pavel Machek <pavel@xxxxxxx> > Sent: Wednesday, July 19, 2023 11:19 AM > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Cc: Lee Jones <lee@xxxxxxxxxx>; Geert Uytterhoeven > <geert+renesas@xxxxxxxxx>; Pavel Machek <pavel@xxxxxxx>; Prabhakar > Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; linux-renesas- > soc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] mfd: rz-mtu3: Improve critical sections > > Hi! > > > Improve critical sections on rz_mtu3_start_stop_ch() and > > rz_mtu3_is_enabled() by moving offset and bitpos computation outside > > the critical section and drop the 'ret' variable on > > rz_mtu3_is_enabled() and return 'tstr & BIT(bitpos)' directly. > > Thanks for the patch. > > Reviewed-by: Pavel Machek <pavel@xxxxxxx> > > This is an improvement, but we'll need to move away from raw_spin_lock > code. I asked tglx, raw_spin_lock is not okay to use without very clear > reason. OK, will replace raw_spin_lock->spin_lock(). Cheers, Biju
