Re: [PATCH] mfd: rz-mtu3: Improve critical sections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> Improve critical sections on rz_mtu3_start_stop_ch() and
> rz_mtu3_is_enabled() by moving offset and bitpos computation
> outside the critical section and drop the 'ret' variable on
> rz_mtu3_is_enabled() and return 'tstr & BIT(bitpos)' directly.

Thanks for the patch.

Reviewed-by: Pavel Machek <pavel@xxxxxxx>

This is an improvement, but we'll need to move away from raw_spin_lock
code. I asked tglx, raw_spin_lock is not okay to use without very
clear reason.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux