RE: [PATCH 2/2] clk: vc7: Use i2c_get_match_data() instead of device_get_match_data()

[Biju Das <biju.das.jz@xxxxxxxxxxxxxx>]

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH 2/2] clk: vc7: Use i2c_get_match_data() instead of
> device_get_match_data()
> 
> Hi Biju,
> 
> On Sun, Jul 16, 2023 at 5:44 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > The device_get_match_data(), is to get match data for firmware
> > interfaces such as just OF/ACPI. This driver has I2C matching table as
> > well. Use
> > i2c_get_match_data() to get match data for I2C, ACPI and DT-based
> > matching.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> > --- a/drivers/clk/clk-versaclock7.c
> > +++ b/drivers/clk/clk-versaclock7.c
> > @@ -1109,7 +1109,9 @@ static int vc7_probe(struct i2c_client *client)
> >
> >         i2c_set_clientdata(client, vc7);
> >         vc7->client = client;
> > -       vc7->chip_info = device_get_match_data(&client->dev);
> > +       vc7->chip_info = i2c_get_match_data(client);
> > +       if (!vc7->chip_info)
> > +               return -ENODEV;
> 
> Can this actually fail? All tables have data pointers.

It is not needed. I just want to avoid people sending
patches as this function can return NULL, so add a check.

Please let me know, whether I should remove this?
I am happy to send V2 taking out this check.

Cheers,
Biju