Hi Biju,
On Sun, Jul 16, 2023 at 5:44 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> The device_get_match_data(), is to get match data for firmware interfaces
> such as just OF/ACPI. This driver has I2C matching table as well. Use
> i2c_get_match_data() to get match data for I2C, ACPI and DT-based
> matching.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> --- a/drivers/clk/clk-versaclock7.c
> +++ b/drivers/clk/clk-versaclock7.c
> @@ -1109,7 +1109,9 @@ static int vc7_probe(struct i2c_client *client)
>
> i2c_set_clientdata(client, vc7);
> vc7->client = client;
> - vc7->chip_info = device_get_match_data(&client->dev);
> + vc7->chip_info = i2c_get_match_data(client);
> + if (!vc7->chip_info)
> + return -ENODEV;
Can this actually fail? All tables have data pointers.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
