Hi Andy,
Thanks for the feedback.
> Subject: Re: [PATCH v4 6/6] serial: 8250_em: Add
> serial8250_em_{reg_update(),out_helper()}
>
> On Fri, Feb 17, 2023 at 02:35:16PM +0000, Biju Das wrote:
> > Hi Andy,
> > > Subject: Re: [PATCH v4 6/6] serial: 8250_em: Add
> > > serial8250_em_{reg_update(),out_helper()}
> > > On Fri, Feb 17, 2023 at 11:42:55AM +0000, Biju Das wrote:
>
> ...
>
> > > > + switch (off) {
> > > > + case UART_FCR_EM:
> > > > + fcr = value;
> > > > + break;
> > > > + case UART_LCR:
> > > > + lcr = value;
> > > > + break;
> > > > + case UART_MCR:
> > > > + mcr = value;
> > >
> > > Missing break; statement.
> >
> > OK, will fix this in next version.
> >
> > The original driver has some missing breaks[1].
> > So for consistency I dropped this. same for below.
>
> I see. Perhaps you can add another patch that adds them there first?
OK, will add separate patch for adding them first.
Cheers,
Biju
