Hi Andy, > Subject: Re: [PATCH v4 2/6] serial: 8250_em: Drop slab.h > > On Fri, Feb 17, 2023 at 02:30:34PM +0000, Biju Das wrote: > > > On Fri, Feb 17, 2023 at 11:42:51AM +0000, Biju Das wrote: > > > > This patch removes the unused header file slab.h. > > > > > > Please, read Submitting Patches on how to make your commit messages > better. > > > > Thanks for the link. > > > > I rechecked slab.h [1] and 8250_em driver is not using any of api's or > > macros provided by that header file. > > Yes, that's not what I'm talking about. > > > Please correct me if that is not the case. > > The following text is okay > > ---8<----8<---- > > serial: 8250_em: Drop unused header file > > Drop unused header file slab.h from the driver. Thanks. I got the point "Describe your changes in imperative mood", I should not use "This patch" in commit messages which looks like giving orders to the codebase to change its behaviour. Cheers, Biju >
