Hi Jiri Slaby, Thanks for the feedback. > Subject: Re: [PATCH v3 1/3] serial: 8250_em: Use dev_err_probe() > > On 10. 02. 23, 21:34, Biju Das wrote: > > This patch simplifies probe() function by using dev_err_probe() > > instead of dev_err in probe(). > > > > While at it, remove the unused header file slab.h and added a local > > variable 'dev' to replace '&pdev->dev' in probe(). > > > > Also replace devm_clk_get->devm_clk_get_enabled and updated the clk > > handling in probe() and remove(). > > Sorry, this "While at it" and "Also" is not allowed in a single patch. > You do three completely distinct things in a single patch. Please separate > (like prints+&dev, slab.h, and clk changes). OK, will split into 3 patches as mentioned above. > > And pretty please, don't send 3 (!) versions a day. Wait a week or so for > reviews of a single version. No need to haste. OK, next time will take care. Cheers, Biju
