Re: [PATCH v3 1/3] serial: 8250_em: Use dev_err_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10. 02. 23, 21:34, Biju Das wrote:
This patch simplifies probe() function by using dev_err_probe()
instead of dev_err in probe().

While at it, remove the unused header file slab.h and added a
local variable 'dev' to replace '&pdev->dev' in probe().

Also replace devm_clk_get->devm_clk_get_enabled and updated the
clk handling in probe() and remove().

Sorry, this "While at it" and "Also" is not allowed in a single patch. You do three completely distinct things in a single patch. Please separate (like prints+&dev, slab.h, and clk changes).

And pretty please, don't send 3 (!) versions a day. Wait a week or so for reviews of a single version. No need to haste.

thanks,
--
js
suse labs




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux