RE: [PATCH] net: ethernet: renesas: rswitch: Fix MAC address info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vladimir,

> From: Vladimir Oltean, Sent: Thursday, November 17, 2022 8:36 AM
> 
> On Wed, Nov 16, 2022 at 03:14:53PM -0800, Saeed Mahameed wrote:
> > On 16 Nov 08:55, Yoshihiro Shimoda wrote:
> > > Smatch detected the following warning.
> > >
> > >    drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn:
> > >    '%pM' cannot be followed by 'n'
> > >
> > > The 'n' should be '\n'.
> > >
> > > Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> > > Suggested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> >
> > I would drop the Fixes tag, this shoiuldn't go to net and -stable. and
> > please tag either [PATCH net] or [PATCH net-next], this one should be
> > net-next.
> >
> > Thanks,
> > you can add:
> > Reviewed-by: Saeed Mahameed <saeed@xxxxxxxxxx>
> 
> You can have a Fixes: tag on a patch sent to net-next no problem.
> No need to drop it.

I got it.

> But in the future, using git-format-patch
> --subject-prefix="PATCH net" (or net-next) would be indeed advisable.

I'll send v2 patch by using --subject-prefix="PATCH v2 net-next".

Best regards,
Yoshihiro Shimoda





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux