Hi Leon,
> From: Leon Romanovsky, Sent: Thursday, November 17, 2022 3:09 PM
>
> On Wed, Nov 16, 2022 at 08:55:19AM +0900, Yoshihiro Shimoda wrote:
> > Smatch detected the following warning.
> >
> > drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn:
> > '%pM' cannot be followed by 'n'
> >
> > The 'n' should be '\n'.
> >
> > Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> > Suggested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> > drivers/net/ethernet/renesas/rswitch.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> > index f3d27aef1286..51ce5c26631b 100644
> > --- a/drivers/net/ethernet/renesas/rswitch.c
> > +++ b/drivers/net/ethernet/renesas/rswitch.c
> > @@ -1714,7 +1714,7 @@ static int rswitch_init(struct rswitch_private *priv)
> > }
> >
> > for (i = 0; i < RSWITCH_NUM_PORTS; i++)
> > - netdev_info(priv->rdev[i]->ndev, "MAC address %pMn",
> > + netdev_info(priv->rdev[i]->ndev, "MAC address %pM\n",
>
> You can safely drop '\n' from here. It is not needed while printing one
> line.
Oh, I didn't know that. I'll remove '\n' from here on v2 patch.
Best regards,
Yoshihiro Shimoda
> Thanks
>
> > priv->rdev[i]->ndev->dev_addr);
> >
> > return 0;
> > --
> > 2.25.1
> >
