On Wed, Nov 16, 2022 at 03:14:53PM -0800, Saeed Mahameed wrote:
> On 16 Nov 08:55, Yoshihiro Shimoda wrote:
> > Smatch detected the following warning.
> >
> > drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn:
> > '%pM' cannot be followed by 'n'
> >
> > The 'n' should be '\n'.
> >
> > Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> > Suggested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
>
> I would drop the Fixes tag, this shoiuldn't go to net and -stable. and
> please tag either [PATCH net] or [PATCH net-next], this one should be
> net-next.
>
> Thanks,
> you can add:
> Reviewed-by: Saeed Mahameed <saeed@xxxxxxxxxx>
You can have a Fixes: tag on a patch sent to net-next no problem.
No need to drop it. But in the future, using git-format-patch
--subject-prefix="PATCH net" (or net-next) would be indeed advisable.
