On 25/07/2022 12:38, Niklas Söderlund wrote:
Hi Daniel,
On 2022-07-25 12:00:30 +0200, Daniel Lezcano wrote:
Hi Niklas,
On 25/07/2022 01:28, Niklas Söderlund wrote:
Hi (again) Daniel,
I figured it out, the thermal zone is disabled after this change. For
both rcar sensors with the new API thermal_zone_device_enable() is never
called.
In the old API the zone is enabled in the call chain of
devm_thermal_zone_of_sensor_register(). While after this change the zone
is not enabled by the core when calling thermal_zone_device_enable().
If I add a call to thermal_zone_device_enable() together with the new
API everything works as before. But I'm not sure if the correct solution
is to add a call to thermal_zone_device_enable() in the sensor drivers
or in the call chain of the new API?
On 2022-07-25 00:39:10 +0200, Niklas Söderlund wrote:
Hi Daniel,
I tested your branch, unfortunately with the same result for
rcar_gen3_thermal. Manipulation of emul_temp file do not trigger
actions.
Thanks for investigating, I updated the branch. Does it fix the issue ?
I tested the branch with the head [1] and it restores the expected
operation for both rcar_gen3_thermal and rcar_thermal sensors.
Thanks for the fix, with this change I'm happy with this new API.
1. commit e9b792a531c10756 ("thermal/of: Remove old OF code")
Thanks !!
