Hi Daniel, On 2022-07-24 20:27:54 +0200, Daniel Lezcano wrote: > > Hi Niklas, > > I tried to reproduce the issue but without success. > > What sensor are you using ? I was using rcar_gen3_thermal. I did my tests starting on v5.19-rc7 and then picked '[PATCH v5 00/12] thermal OF rework' from [1] and finally applied this full series on-top of that. If you have a branch or some specific test you wish me to try I'm happy to so. 1. https://lore.kernel.org/lkml/20220710123512.1714714-1-daniel.lezcano@xxxxxxxxxx/ > > > On 19/07/2022 11:10, Niklas Söderlund wrote: > > Hi Daniel, > > > > Thanks for your work. > > > > On 2022-07-10 23:24:07 +0200, Daniel Lezcano wrote: > > > The thermal OF code has a new API allowing to migrate the OF > > > initialization to a simpler approach. > > > > > > Use this new API. > > I tested this together with the series it depends on and while > > temperature monitoring seems to work fine it breaks the emul_temp > > interface (/sys/class/thermal/thermal_zone2/emul_temp). > > > > Before this change I can write a temperature to this file and have it > > trigger actions, in my test-case changing the cooling state, which I > > observe in /sys/class/thermal/cooling_device0/cur_state. > > > > Likewise before this change I could trip the critical trip-point that > > would power off the board using the emul_temp interface, this too no > > longer works, > > > > echo 120000 > /sys/class/thermal/thermal_zone2/emul_temp > > > > Is this an intention change of the new API? > > > > -- Kind Regards, Niklas Söderlund