Re: [PATCH v1 17/33] thermal/drivers/rcar: Switch to new of API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Niklas,

I give another try but failed to reproduce the issue. Perhaps my board has a path different from yours.

Thanks for proposing to test the series. I've uploaded the branch here:

https://github.com/dlezcano/linux-thermal


On 24/07/2022 21:00, Niklas Söderlund wrote:
Hi Daniel,

On 2022-07-24 20:27:54 +0200, Daniel Lezcano wrote:
Hi Niklas,

I tried to reproduce the issue but without success.

What sensor are you using ?
I was using rcar_gen3_thermal.

I did my tests starting on v5.19-rc7 and then picked '[PATCH v5 00/12]
thermal OF rework' from [1] and finally applied this full series on-top
of that. If you have a branch or some specific test you wish me to try
I'm happy to so.

1. https://lore.kernel.org/lkml/20220710123512.1714714-1-daniel.lezcano@xxxxxxxxxx/


On 19/07/2022 11:10, Niklas Söderlund wrote:
Hi Daniel,

Thanks for your work.

On 2022-07-10 23:24:07 +0200, Daniel Lezcano wrote:
The thermal OF code has a new API allowing to migrate the OF
initialization to a simpler approach.

Use this new API.
I tested this together with the series it depends on and while
temperature monitoring seems to work fine it breaks the emul_temp
interface (/sys/class/thermal/thermal_zone2/emul_temp).

Before this change I can write a temperature to this file and have it
trigger actions, in my test-case changing the cooling state, which I
observe in /sys/class/thermal/cooling_device0/cur_state.

Likewise before this change I could trip the critical trip-point that
would power off the board using the emul_temp interface, this too no
longer works,

      echo 120000 > /sys/class/thermal/thermal_zone2/emul_temp

Is this an intention change of the new API?







[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux