Re: [PATCH v2 2/5] can: rcar_canfd: Add support for r8a779a0 SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On 01/12/2022 7:43 PM Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> > +#define IS_V3U (gpriv->chip_id == RENESAS_R8A779A0)
> 
> I really don't like this macro, as it silently relies on gpriv....and
> I really don't like this use of this macro in the other macros that lead
> to 2 or even 3 ternary operators hiding inside them. Is there any chance
> to change this?

Good point. I guess I should turn that into a function.

CU
Uli



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux